Re: [PATCH 07/37] Security: De-embed task security record from task and use refcounting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Morris <jmorris@xxxxxxxxx> wrote:

> > Remove the temporarily embedded task security record from task_struct.
> > Instead it is made to dangle from the task_struct::sec and
> > task_struct::act_as pointers with references counted for each.
> 
> ...
> 
> These patches are kind of huge.

Yeah, I know.  The problem is that each patch must compile and run.  They
can't be split up without violating that unfortunately.

> Why manually copy these fields after a kmemdup?

Fair point.  Fixed.

> What about the task backpointer? (i.e. tsec2->task)

The problem is that there can't be one with this patch as the task_security
struct and the LSM security data attached to it may outlive the task it points
back to.

It seems that the backpointer can be dispensed with.  Nothing particularly
seems to use it.  Do you know the reason for its existence?

David

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with
the words "unsubscribe selinux" without quotes as the message.

[Index of Archives]     [Selinux Refpolicy]     [Linux SGX]     [Fedora Users]     [Fedora Desktop]     [Yosemite Photos]     [Yosemite Camping]     [Yosemite Campsites]     [KDE Users]     [Gnome Users]

  Powered by Linux