Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote: > This is pretty nasty. Why? If the fs doesn't set PG_private or PG_fscache on any pages before calling read_cache_pages(), there's no difference. Furthermore, the differences only crop up in the error handling paths. > I would suggest either to have the function return the number of pages that > were added to pagecache, Which helps how? > or just open code it. Well, I could give an alternative read_cache_pages(), I suppose, for just this situation, but that means there are two parallel functions which then both need to be maintained. David -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to majordomo@xxxxxxxxxxxxx with the words "unsubscribe selinux" without quotes as the message.