On 2/9/19 5:25 AM, Russell Coker wrote:
define(`read_file_perms',`{ getattr open read lock ioctl }') define(`mmap_read_file_perms',`{ getattr open map read ioctl }') I think that the general expectation would be that mmap_read_file_perms is a superset of read_file_perms. Is there any reason why mmap_read_file_perms doesn't include lock permission? If not I think we should add it to avoid surprises.
You are correct, it should be a proper superset. However, my preference would be to go the other way and eliminate lock from read_file_perms, which is what I'm trying to do with mmap_read_file_perms not being a proper superset.
-- Chris PeBenito