Re: [PATCH 4/6] block: stop setting ->direct_IO

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Christoph Hellwig <hch@xxxxxx>

Subject: Re: [PATCH 4/6] block: stop setting ->direct_IO

From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Date: Tue, 29 Aug 2023 03:13:37 +0100

Arc-authentication-results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=PAFIQnX8; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@xxxxxxxxxxxxxxxx has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@xxxxxxxxxxxxxxxx

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693275225; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WSpE78AlAGSFYIPZmWk0Cvmp1sPO7AW6n90ce46uOYM=; b=YHpRKRLv9DWDKkTW23JDB8I1bYF1vHGCn8B0AXFT4EvvPMWzhGuOfdzAF1HP91CahYXAPI dAWftJ2A7IBsIEs1lecT6avotz6Tp+BrWvqi/p/EJM3B/ky27e16RiGZaBpWFEgKRvWJzR Jy79EQrihTRqm3ANdAZUXFp2iNJSuPY=

Arc-seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693275225; a=rsa-sha256; cv=none; b=RL+CnreeQ33+YdrnEWIn1Gq4JxaOjZMgF9J/wFulYhbHuSQgWLMmMsnbV/VpMws8DaSGtE ogYbir+6qT+uTHw9prCe2BJDDTp95C0WNchsDCuV4Dn5BTT71H8CSn44xgyf390wyZrR+W a1LvFgI9lyZdcDS9xZD/NkqVa81GBpI=

Authentication-results: mx.google.com; dkim=fail header.i=@linux.org.uk header.s=zeniv-20220401 header.b=PAFIQnX8; arc=fail (signature failed); spf=pass (google.com: domain of owner-linux-mm@xxxxxxxxx designates 205.233.56.17 as permitted sender) smtp.mailfrom=owner-linux-mm@xxxxxxxxx; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk

Authentication-results: imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=PAFIQnX8; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@xxxxxxxxxxxxxxxx has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@xxxxxxxxxxxxxxxx

Cc: Jens Axboe <axboe@xxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Christian Brauner <christian@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Luis Chamberlain <mcgrof@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Johannes Thumshirn <johannes.thumshirn@xxxxxxx>

Delivered-to: spinic@xxxxxxxxx

Delivered-to: linux-mm-outgoing@xxxxxxxxx

In-reply-to: <20230801172201.1923299-5-hch@lst.de>

References: <20230801172201.1923299-1-hch@lst.de> <20230801172201.1923299-5-hch@lst.de>

On Tue, Aug 01, 2023 at 07:21:59PM +0200, Christoph Hellwig wrote:
> Direct I/O on block devices now nevers goes through aops->direct_IO.
> Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead.

s/nevers/never/