Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-12-04 11:50:07 [+0100], Greg Kroah-Hartman wrote:
> From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> 
> commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream.
> 
> --- a/arch/x86/kernel/fpu/signal.c
> +++ b/arch/x86/kernel/fpu/signal.c
> @@ -344,10 +344,10 @@ static int __fpu__restore_sig(void __use
>  			sanitize_restored_xstate(tsk, &env, xfeatures, fx_only);
>  		}
>  
> +		local_bh_disable();
>  		fpu->initialized = 1;
> -		preempt_disable();
>  		fpu__restore(fpu);
> -		preempt_enable();
> +		local_bh_enable();

This hits stable trees now. For -RT we need a preempt_disable() before
that local_bh_disable(). I'm going to add this to next v4.19-RT but if
you happen to "just" update to the next stable be aware of that.

>  		return err;
>  	} else {

Sebastian



[Index of Archives]     [Linux USB Development]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux