Re: [v1][PATCH] cpu_down: move migrate_enable() back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tiejun Chen | 2013-11-07 10:06:07 [+0800]:

>Commit 08c1ab68, "hotplug-use-migrate-disable.patch", intends to
>use migrate_enable()/migrate_disable() to replace that combination
>of preempt_enable() and preempt_disable(), but actually in
>!CONFIG_PREEMPT_RT_FULL case, migrate_enable()/migrate_disable()
>are still equal to preempt_enable()/preempt_disable(). So that
>followed cpu_hotplug_begin()/cpu_unplug_begin(cpu) would go schedule()
>to trigger schedule_debug() like this:
>
>_cpu_down()
>	|
>	+ migrate_disable() = preempt_disable()
>	|
>	+ cpu_hotplug_begin() or cpu_unplug_begin()
>		|
>		+ schedule()
>			|
>			+ __schedule()
>				|
>				+ preempt_disable();
>				|
>				+ __schedule_bug() is true!
>
>So we should move migrate_enable() as the original scheme.
>
>Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>

applied.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe stable-rt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Development]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux