Hi Hyeonwoo, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hyeonwoo-Cha/Fix-issue-in-mark_buffer_dirty_inode/20240604-140958 base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all patch link: https://lore.kernel.org/r/20240604060636.87652-1-chw1119%40hanyang.ac.kr patch subject: [PATCH v2] Fix issue in mark_buffer_dirty_inode config: i386-randconfig-141-20240604 (https://download.01.org/0day-ci/archive/20240605/202406050218.U7c0DL3C-lkp@xxxxxxxxx/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202406050218.U7c0DL3C-lkp@xxxxxxxxx/ smatch warnings: fs/buffer.c:673 mark_buffer_dirty_fsync() warn: if statement not indented fs/buffer.c:682 mark_buffer_dirty_fsync() warn: inconsistent indenting vim +673 fs/buffer.c 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 667 void mark_buffer_dirty_fsync(struct buffer_head *bh, struct address_space *mapping) ^1da177e4c3f41 Linus Torvalds 2005-04-16 668 { abc8a8a2c7dc7b Matthew Wilcox (Oracle 2022-12-15 669) struct address_space *buffer_mapping = bh->b_folio->mapping; ^1da177e4c3f41 Linus Torvalds 2005-04-16 670 ^1da177e4c3f41 Linus Torvalds 2005-04-16 671 mark_buffer_dirty(bh); 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 672 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 @673 if (bh->b_assoc_map) 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 674 return; The code is okay, but the indenting is messed up. 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 675 600f111ef51dc2 Matthew Wilcox (Oracle 2023-11-17 676) if (!mapping->i_private_data) { 600f111ef51dc2 Matthew Wilcox (Oracle 2023-11-17 677) mapping->i_private_data = buffer_mapping; ^1da177e4c3f41 Linus Torvalds 2005-04-16 678 } else { 600f111ef51dc2 Matthew Wilcox (Oracle 2023-11-17 679) BUG_ON(mapping->i_private_data != buffer_mapping); ^1da177e4c3f41 Linus Torvalds 2005-04-16 680 } 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 681 600f111ef51dc2 Matthew Wilcox (Oracle 2023-11-17 @682) spin_lock(&buffer_mapping->i_private_lock); 73295b4ed00de6 Hyeonwoo Cha 2024-06-04 683 list_move_tail(&bh->b_assoc_buffers, &mapping->i_private_list); 58ff407bee5a55 Jan Kara 2006-10-17 684 bh->b_assoc_map = mapping; 600f111ef51dc2 Matthew Wilcox (Oracle 2023-11-17 685) spin_unlock(&buffer_mapping->i_private_lock); ^1da177e4c3f41 Linus Torvalds 2005-04-16 686 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
