Hi Geert, On Monday, September 18th, 2023 at 10:58, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Jan, > > On Mon, Sep 18, 2023 at 3:26 PM Jan Kara jack@xxxxxxx wrote: > > > On Mon 18-09-23 12:58:26, Peter Lafreniere wrote: > > > > > ReiserFS has been deprecated for a year and a half, yet is still built > > > as part of a defconfig UML kernel. > > > > > > According to commit eb103a51640e ("reiserfs: Deprecate reiserfs"), the > > > filesystem is slated to be removed in 2025. Remove it from the defconfig > > > profile now, as part of its deprecation process. > > > > > > Signed-off-by: Peter Lafreniere peter@xxxxxxxx > > > > Makes sense but I've noticed there are many more architectures that define > > CONFIG_REISERFS_FS in their defconfig (sh, powerpc, mips, m68k, ia64, arm, > > alpha). So perhaps we should do this for all of them when we are at it? > > > The policy for the m68k defconfigs is to enable all available exotic > file systems as modules, so support for them is available when needed. > > Please let me know why this should be changed, as long as ReiserFS is > still available in the upstream kernel. I understand that policy and it makes particular sense for older/hobbyist hardware like the m68k classic where ReiserFS is included in make defconfig. However, ReiserFS is deprecated and should be phased out as best as possible before its removal, and pruning config options for a filesystem that is considered obsolete and should not be used on the newest kernels is a step towards that. ReiserFS is still availiable to be configured by anyone who builds their own kernel and is still availiable in all(mod|yes)config. As such I can justify the removal of some old config options that doesn't actually remove support for the filesystem when it simplifies the deprecation and removal processes for an ancient, largely unused filesystem. Please remember that users who build and install their own kernel on hobbyist hardware should be capable enough to select one Kconfig option if they happen to need ReiserFS. If not, then removing ReiserFS from the defconfig on a kernel update is an easier issue to work around than waiting to remove the filesystem from the tree entirely. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Cheers, Peter Lafreniere <peter@xxxxxxxx> And I sent the wrong email the first time. So sorry about that.