Re: [PATCH] reiserfs: don't use congestion_wait()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed 17-11-21 15:34:42, NeilBrown wrote:
> Block devices do not, in general, report congestion any more, so this
> congestion_wait() is effectively just a sleep.
> It isn't entirely clear what is being waited for, but as we only wait
> when j_async_throttle is elevated, it seems reasonable to stop waiting
> when j_async_throttle becomes zero - or after the same timeout.
> So change to use wait_event_event_timeout() for waiting, and
> wake_up_var() to signal an end to waiting.
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> ---
> I have no idea who might take this.... Jens and Jan have both landed
> reiserfs patches recently...

Yeah, I guess I can take this one. Honestly the whole code around
j_async_throttle looks a bit suspicious but your patch does not make it
worse so it looks safe to me :).

Jan Kara <jack@xxxxxxxx>

[Index of Archives]     [Linux File System Development]     [Linux BTRFS]     [Linux NFS]     [Linux Filesystems]     [Ext4 Filesystem]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Resources]

  Powered by Linux