Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Wed, 13 Oct 2021 19:44:38 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx
In-reply-to: <20211013051042.1065752-12-hch@lst.de>

On Wed, Oct 13, 2021 at 07:10:24AM +0200, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.

Just IMO, this patch looks like it wants a new bdev_nr_bytes() helper
instead of using the double shifting sectors back to bytes.

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it
Next by Date: Re: don't use ->bd_inode to access the block device size
Previous by thread: Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it
Next by thread: [PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it
Index(es):
- Date
- Thread

[Index of Archives] [Linux File System Development] [Linux BTRFS] [Linux NFS] [Linux Filesystems] [Ext4 Filesystem] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Resources]