On Tue 08-06-21 13:44:43, Pavel Skripkin wrote: > On Mon, 17 May 2021 15:08:18 +0200 > Jan Kara <jack@xxxxxxx> wrote: > > > On Mon 17-05-21 15:15:45, Pavel Skripkin wrote: > > > syzbot reported divide error in reiserfs. > > > The problem was in incorrect journal 1st block. > > > > > > Syzbot's reproducer manualy generated wrong superblock > > > with incorrect 1st block. In journal_init() wasn't > > > any checks about this particular case. > > > > > > For example, if 1st journal block is before superblock > > > 1st block, it can cause zeroing important superblock members > > > in do_journal_end(). > > > > > > Reported-by: syzbot+0ba9909df31c6a36974d@xxxxxxxxxxxxxxxxxxxxxxxxx > > > Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx> > > > > Thanks! I've added the patch to my tree. > > > > Honza > > > > Hi, Jan! > > Is this patched got lost somehow? I did't find it in your tree here > https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/. > > Sorry to bother you, maybe Im missing something :) It's sitting in my for_next branch as commit a149127be52f. I'll push it to Linus in the coming merge window. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR