Nevermind. I just wasn't reproducing properly. Jan's analysis is right. The -EOPNOTSUPP change is required so that we get the right error when explicit xattr operations are performed on a file system without them. Prior to this change, we'd get -EOPNOTSUPP by sb->s_xattr being NULL. reiserfs_for_each_xattr needs to handle this the same way we already handle -ENODATA. -Jeff On 1/15/20 12:03 PM, Jeff Mahoney wrote: > Hi Michael - > > It looks like something must've gone sideways with the backport since > 5.5-rc6 works as expected. I'll dig into it a bit. > > -Jeff > > On 1/14/20 3:21 PM, Michael Brunnbauer wrote: >> >> hi all, >> >> is this been looked into? Do you need more information? >> >> Regards, >> >> Michael Brunnbauer >> >> On Thu, Jan 09, 2020 at 01:30:41PM +0100, Michael Brunnbauer wrote: >>> >>> Hello Jan, >>> >>> On Thu, Jan 09, 2020 at 01:12:16PM +0100, Jan Kara wrote: >>>> Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it >>>> just that the kernel is spewing these annoying warnings? Because from the >>>> code reading I'd think that it is only the kernel spewing errors but >>>> userspace should be fine... >>> >>> Yes, 'cp -a' returns errors and files are owned by root instead of the correct >>> user after copying as root. >>> >>> Regards, >>> >>> Michael Brunnbauer > > -- Jeff Mahoney Director, SUSE Labs Data & Performance
Attachment:
signature.asc
Description: OpenPGP digital signature
