On Fri, 26 Jul 2019 16:38:38 +0800 Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote: > In remove_from_transaction(), there is an if statement on line 3447 to > check whether bh is NULL: > if (bh) We already know that bh != NULL here. cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr); if (!cn || !cn->bh) { return ret; } bh = cn->bh; Please prepare a patch to remove the unneeded test?