On Wed 20-06-18 16:25:04, Arnd Bergmann wrote: > Before linux-2.4.6, print_time() was used to pretty-print an inode > time when running reiserfs in user space, after that it has become > obsolete and is still a bit incorrect: It behaves differently on 32-bit > and 64-bit machines, and uses a static buffer to hold a string, which > could lead to undefined behavior if we ever called this from multiple > places simultaneously. > > Since we always want to treat the timestamps as 'unsigned' anyway, > simply printing them as an integer is both simpler and safer while > avoiding the deprecated time_t type. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > v2: after a second look, I decided to remove it instead of fixing it. Yes, that's a good idea. The patch looks good. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
