Re: [xfstests/generic/081] Kernel panic with reg40 plugin and R4-for-4.1.5.patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Actually, this is not a regression.
The attached patch prevents the panic.
By default on IO errors reiser4 partition will be remounted as "readonly".

No ideas why accessing /dev/dm-X causes IO error.
Reiser4 is not the culprit ;) You can narrow down this, if interesting.
I think that something is wrong with LVM settings...

Thanks,
Edward.


On 09/04/2015 09:35 AM, Dušan Čolić wrote:
Kernel: 4.1.6
R4 patch: 4.1.5
Test: xfstests/generic/081 "Test I/O error path by fully filling an dm
snapshot."

Test passes cleanly with ccreg40 but kernel panics with reg40 plugin.
Picture of the panic, as I had no other means of capturing it, is in attachment.

xfstests local.config section:

[r4Hybrid]
MKFS_OPTIONS="-o create=reg40"
MOUNT_OPTIONS="-o noatime"

Have a nice day.

Dushan

Don't panic by default on IO errors, remount ro instead 

Signed-off-by: Edward Shishkin <edward.shishkin@xxxxxxxxx>
---
 fs/reiser4/vfs_ops.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/reiser4/vfs_ops.c
+++ b/fs/reiser4/vfs_ops.c
@@ -232,9 +232,8 @@ void reiser4_handle_error(void)
 	reiser4_status_write(REISER4_STATUS_DAMAGED, 0,
 			     "Filesystem error occured");
 	switch (get_super_private(sb)->onerror) {
-	case 0:
-		reiser4_panic("foobar-42", "Filesystem error occured\n");
 	case 1:
+		reiser4_panic("foobar-42", "Filesystem error occured\n");
 	default:
 		if (sb->s_flags & MS_RDONLY)
 			return;

[Index of Archives]     [Linux File System Development]     [Linux BTRFS]     [Linux NFS]     [Linux Filesystems]     [Ext4 Filesystem]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Resources]

  Powered by Linux