On Tuesday 21 October 2014 at 17:50:23, Edward Shishkin wrote:
> On 08/17/2014 11:52 PM, Ivan Shapovalov wrote:
> > Signed-off-by: Ivan Shapovalov<intelfx100@xxxxxxxxx>
> > ---
> > fs/reiser4/block_alloc.h | 5 +++--
> > fs/reiser4/plugin/space/bitmap.c | 3 ++-
> > 2 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/reiser4/block_alloc.h b/fs/reiser4/block_alloc.h
> > index bfc6be9..08b3941 100644
> > --- a/fs/reiser4/block_alloc.h
> > +++ b/fs/reiser4/block_alloc.h
> > @@ -51,9 +51,10 @@ struct reiser4_blocknr_hint {
> > /* block allocator assumes that blocks, which will be mapped to disk,
> > are in this specified block_stage */
> > block_stage_t block_stage;
> > - /* If direction = 1 allocate blocks in backward direction from the end
> > - * of disk to the beginning of disk. */
> > + /* Allocate blocks only in backward direction starting from blk. */
> > unsigned int backward:1;
> > + /* Allocate blocks only in forward direction starting from blk. */
> > + unsigned int forward:1;
>
>
> I suggest to call this bitfield "monotonic_forward"
Isn't it an opposite of "backward"? Should we rename both?
BTW, in plugin/space/bitmap.c:1141 (around that line)
in function alloc_blocks_forward()
shouldn't the second scan be done with bitmap_alloc_backward(), as per the
comment?
Thanks,
--
Ivan Shapovalov / intelfx /
> >
> > };
> >
> > diff --git a/fs/reiser4/plugin/space/bitmap.c b/fs/reiser4/plugin/space/bitmap.c
> > index 3da3f6b..9beaf66 100644
> > --- a/fs/reiser4/plugin/space/bitmap.c
> > +++ b/fs/reiser4/plugin/space/bitmap.c
> > @@ -1127,7 +1127,8 @@ static int alloc_blocks_forward(reiser4_blocknr_hint *hint, int needed,
> > /* There is only one bitmap search if max_dist was specified or first
> > pass was from the beginning of the bitmap. We also do one pass for
> > scanning bitmap in backward direction. */
> > - if (!(actual_len != 0 || hint->max_dist != 0 || search_start == 0)) {
> > + if (actual_len == 0 && search_start != 0 &&
> > + hint->max_dist == 0 && hint->forward == 0) {
> > /* next step is a scanning from 0 to search_start */
> > search_end = search_start;
> > search_start = 0;
>
>
> OK with this patch,
> I'll continue to review this patch series at leisure.
>
> Thanks,
> Edward.Attachment:
signature.asc
Description: This is a digitally signed message part.
