On 06/17/2014 08:31 PM, Ivan Shapovalov wrote:
On Tuesday 17 June 2014 at 12:29:53, Edward Shishkin wrote:
On 06/17/2014 12:14 PM, Ivan Shapovalov wrote:
On Tuesday 17 June 2014 at 02:37:16, Edward Shishkin wrote:
[...]
Yup, blocknr sets minimize memory consumption and are unsortable...
I think that the cleanest option will be using lists (instead of blocknr
sets) for
the delete sets, if the discard is turned on. It will reduce memory
consumption
by 20%. Indeed, every entry in a blocknr_set occupies ~8 bytes (assuming
that everything is pretty fragmented because of txmod=wa), whereas a list
entry occupies 32 bytes (start, length, plus 2 pointers for the link).
In this option we'll need to join lists (instead of merging blocknr
sets) during
atoms fusion and apply the list (instead of blocknr set) to the COMMIT
BITMAP
at pre_commit_hook(). I think it won't be a problem, since the lists are
simpler
than blocknr sets.
That's a neat approach. I think I'll use unions and do the decision at runtime.
Yup.
So, if discard is on, we work with 2 lists (delete_set,
delete_set_for_wander).
If discard is off, we work with one blocknr set..
Good. So I'll do roughly following for v5:
- rename discard_set_* to block_list_* and split off these definitions
How about blocknr_lst_*?
- write a family of reiser4_atom_dset_*() (log_deferred, log_immediate,
Can we avoid "log" if possible? Logs live in the journals...
Let's use "add_extent" instead of "log".
apply_deferred, merge, init, destroy) which will encapsulate discard/nodiscard
check and operate on correct lists (blocknr_set vs block_list)
- call reiser4_atom_dset_{init,destroy,merge}() from respective functions
- call reiser4_atom_dset_log_{deferred,immediate}() from reiser4_dealloc_blocks()
Let's do something like this:
reiser4_dealloc_blocks
{
...
if (flags & BA_DEFER)
atom_dset_defer_add_extent(atom, &bsep, start, len);
else
....
sa_dealloc_blocks();
atom_dset_immed_add_extent(...);
...
}
where
atom_dset_defer_add_extent() encapsulates
1) the loop
do {
blocknr_set_add_extent (atom, &atom->delete_set_defer, &bsep,
start, len);
...
} while (ret == -E_REPEAT);
2) blocknr_lst_add_extent (&atom->delete_set_defer, start, len);
atom_dset_immed_add_extent() encapsulates
blocknr_lst_add_extent (&atom->delete_set_immed, start, len);
etc.
- call reiser4_atom_dset_apply_deferred() from reiser4_post_commit_hook()
- directly manipulate the block lists from discard_atom(), checking that we
indeed have discard enabled
OK.
Thanks,
Edward.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
