On Wed 23-04-14 10:00:44, Jeff Mahoney wrote:
> The hash detection code uses long ugly macros multiple times to get the same
> value. This patch cleans it up to be easier to read.
>
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
> ---
> fs/reiserfs/super.c | 108 ++++++++++++++++++++++++----------------------------
> 1 file changed, 50 insertions(+), 58 deletions(-)
>
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -1668,71 +1668,63 @@ static __u32 find_hash_out(struct super_
...
> +
> + if (deh_hashval == yurahash)
> + hash = YURA_HASH;
> + else if (deh_hashval == teahash)
> + hash = TEA_HASH;
> + else if (deh_hashval == r5hash)
> + hash = R5_HASH;
> + else {
> + reiserfs_warning(s, "reiserfs-2506",
> + "Unrecognised hash function");
> + hash = UNSET_HASH;
> + goto out;
> + }
> + return hash;
But you don't call pathrelse(&path) for some cases it seems while
previously it has been called always. Or am I missing something?
Honza
>
> +out:
> pathrelse(&path);
> return hash;
> }
>
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
