On Sat, 22 Mar 2014 13:32:07 -0400 tytso@xxxxxxx wrote: > On Sat, Mar 22, 2014 at 01:26:06PM -0400, tytso@xxxxxxx wrote: > > > Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is > > > good. Adding new retry-for-ever code is not good. > > Oh, and BTW --- now that checkpatch.pl now flags an warning whenever > GFP_NOFAIL is used I don't know what the basis for this NOFAIL-is-going-away theory could have been. What's the point in taking a centrally implemented piece of logic and splattering its implementation out to tens of different callsites? Obviously I was asleep when I merged that checkpatch change. From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: scripts/checkpatch.pl: __GFP_NOFAIL isn't going away Revert 7e4915e78992eb ("checkpatch: add warning of future __GFP_NOFAIL use"). There are no plans to remove __GFP_NOFAIL. __GFP_NOFAIL exists to a) centralise the retry-allocation-for-ever operation into the core allocator, which is the appropriate implementation site and b) permit us to identify code sites which aren't handling memory exhaustion appropriately. Cc: David Rientjes <rientjes@xxxxxxxxxx> Cc: Joe Perches <joe@xxxxxxxxxxx> Cc: Theodore Ts'o <tytso@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 6 ------ 1 file changed, 6 deletions(-) diff -puN scripts/checkpatch.pl~scripts-checkpatchpl-__gfp_nofail-isnt-going-away scripts/checkpatch.pl --- a/scripts/checkpatch.pl~scripts-checkpatchpl-__gfp_nofail-isnt-going-away +++ a/scripts/checkpatch.pl @@ -4240,12 +4240,6 @@ sub process { "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr); } -# check for GFP_NOWAIT use - if ($line =~ /\b__GFP_NOFAIL\b/) { - WARN("__GFP_NOFAIL", - "Use of __GFP_NOFAIL is deprecated, no new users should be added\n" . $herecurr); - } - # check for multiple semicolons if ($line =~ /;\s*;\s*$/) { if (WARN("ONE_SEMICOLON", _ -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html