-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Al Viro wrote: > On Mon, May 04, 2009 at 12:51:20AM -0400, Jeff Mahoney wrote: > >> Huh. I didn't see that still in there. That's an artifact of an earlier >> version of the code where I kept a reference to /.reiserfs_priv/xattrs. >> Then I decided that .reiserfs_priv was all I needed to cache (to avoid >> recursive i_mutex locking on the fs root) and dropped the caching of >> xattrs. Looks like it didn't get totally cleared out. > > It's not that simple ;-/ You check it in journalling code, AFAICS in order > to decide how much will that sucker take (due to extra mkdir?) and something > will need to be done with that check. Yes, it's for an extra mkdir. Now that I've gotten some sleep and looked at the code again, I see what you're saying. At least it's broken in a performance way instead of causing a system crash or data corruption. > Anyway, I'm going to push all that stuff to #for-next, so that -next would > pick it. I have *not* touched the xattr_root logics, so if you could do > that on top of your patch + my incremental... Ok, I'll fix that up and get some testing in. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkn/Gn4ACgkQLPWxlyuTD7KclACeLNAOawW5fDxc2CqGZz4NUXpY 21AAoJdsK3EEPweBCuv1131j3Lm8x3lk =0Iqb -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
