On Wed, 18 Feb 2009 15:06:26 +0100 Nick Piggin <npiggin@xxxxxxx> wrote: > On Wed, Feb 18, 2009 at 04:27:02PM +0300, Edward Shishkin wrote: > > > > Maybe it makes sense to add comments with warnings > > > > in all such places, or create a header file with a static inline > > > > function update_page_accounting() ? > > > > > > Could just uninline the helper function I guess - if you look, those > > > four statements already involve doing a heck of a lot of stuff. > > > > > > Try it, see how it looks? > > > > > > > Done. > > Please, review. > > > > Add/use a helper function update_page_accounting(). > > Fine patch, except the name I don't like. account_set_page_dirty, or > account_page_dirtied, or something to hint it is for accounting > dirty. yep, sorry, I didn't think too hard about that for-example. I'll edit the diffs.. -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
