Jeff Mahoney wrote:
> Jeff Mahoney wrote:
>> j_flush_sem is a semaphore but uses it as if it were a mutex. This
>> patch converts it to a mutex.
>> --- a/fs/reiserfs/journal.c
>> +++ b/fs/reiserfs/journal.c
>> @@ -1411,8 +1411,8 @@ static int flush_journal_list(struct sup
>>
>> /* if flushall == 0, the lock is already held */
>> if (flushall) {
>> - down(&journal->j_flush_sem);
>> - } else if (!down_trylock(&journal->j_flush_sem)) {
>> + mutex_lock(&journal->j_flush_mutex);
>> + } else if (!mutex_trylock(&journal->j_flush_mutex)) {
>> BUG();
>> }
>
> Oops. This chunk didn't get refreshed, here's the right one.
>
> -Jeff
Thanks, the patch resolves the kernel bug.
Tested-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
> ---
> fs/reiserfs/journal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -1410,7 +1410,7 @@ static int flush_journal_list(struct sup
> /* if flushall == 0, the lock is already held */
> if (flushall) {
> mutex_lock(&journal->j_flush_mutex);
> - } else if (!mutex_trylock(&journal->j_flush_mutex)) {
> + } else if (mutex_trylock(&journal->j_flush_mutex)) {
> BUG();
> }
>
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
