On Tue, Nov 19, 2024 at 03:29:49PM +0800, Feng Lee wrote:
> We will perform GP sequence checking at the beginning of srcu_gp_start,
> thus making it safe to remove duplicate GP sequence checks prior to
> calling srcu_gp_start.
>
> Signed-off-by: Feng Lee <379943137@xxxxxx>
Pulled in unofficially for testing and review, thank you!
Thanx, Paul
> ---
> kernel/rcu/srcutree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 5e2e53464794..cbef5674d201 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -1076,7 +1076,6 @@ static void srcu_funnel_gp_start(struct srcu_struct *ssp, struct srcu_data *sdp,
> /* If grace period not already in progress, start it. */
> if (!WARN_ON_ONCE(rcu_seq_done(&sup->srcu_gp_seq, s)) &&
> rcu_seq_state(sup->srcu_gp_seq) == SRCU_STATE_IDLE) {
> - WARN_ON_ONCE(ULONG_CMP_GE(sup->srcu_gp_seq, sup->srcu_gp_seq_needed));
> srcu_gp_start(ssp);
>
> // And how can that list_add() in the "else" clause
> --
> 2.47.0
>
>
