On 11/28/24 5:24 PM, Uladzislau Rezki wrote: > On Mon, Nov 25, 2024 at 12:18:19PM +0100, Uladzislau Rezki wrote: >>> On 11/20/24 13:37, Uladzislau Rezki wrote: >>>> Thank you. Let me try to start moving it into mm/. I am thinking to place >>>> it to the slab_common.c file. I am not sure if it makes sense to have a >>>> dedicated file name for this purpose. >>> >>> Yeah sounds good. slub.c is becoming rather large and this should not >>> interact with SLUB internals heavily anyway, slab_common.c makes sense. >>> Thanks! >>> >> Got it :) >> > There is one question. Do you think it works if i do a migration as one > big commit? I am asking, because it is easier to go that way. Hi, I think one big move is fine. In case there are further adjustments, those would be better in separate patches. That makes it easy to review the move with git diff --color-moved. Thanks, Vlastimil > If it looks ugly for you, we can use another approach which is to split > the work into several patches and deploy it a series. > > -- > Uladzislau Rezki
