On Mon, Aug 19, 2024 at 03:18:02PM GMT, Paul E. McKenney wrote: > On Mon, Aug 19, 2024 at 12:59:35PM -0400, Kent Overstreet wrote: > > This nets us a slight performance increase, and converts to common > > code. > > How did you measure the performance, and what was the actual amount > of the increase? > > Either way, the performance increase needs to be verified by the people > for whom the current code works well. As noted a couple months ago, > I am having a hard time imagining a tree beating a linked list of pages > of pointers in terms of cache locality. I added linux-arch on CC in > case I am out of date on how computer systems work. The point isn't performance, I was just noting what I saw, and the small performance increase just came from carefull optimization, nothing special. The old and new versions are close enough to not matter. The point of the patchset is to consolidate kvfree_rcu() and SLAB_TYPESAFE_BY_RCU into something more general, and dare I say it, something a bit saner.