Re: [PATCH v2] srcu: Improve comments about acceleration leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le Sun, Dec 17, 2023 at 09:00:15PM -0500, Joel Fernandes a écrit :
> "Acceleration can never fail because the state of gp_seq value used
> for acceleration is <= the state of gp_seq used for advancing."
> 
> Does that sound correct now?

That can be confusing since acceleration relies on rcu_seq_snap() while
advance relies on rcu_seq_current(). And rcu_seq_snap() returns a snapshot
that may be above the subsequent rcu_seq_current() return value.

So it should rather be something like:

"The base current gp_seq value used to produce the snapshot has to
be <= the gp_seq used for advancing."

Thanks.




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux