Now that rcutiny can deal with early boot PF_IDLE setting, revert
commit cff9b2332ab762b7e0586c793c431a8f2ea4db04.
This fixes several subtle issues introduced on RCU-tasks(-trace):
1) RCU-tasks stalls when:
1.1 Grace period is started before init/0 had a chance to set PF_IDLE,
keeping it stuck in the holdout list until idle ever schedules.
1.2 Grace period is started when some possible CPUs have never been
online, keeping their idle tasks stuck in the holdout list until
the CPU ever boots up.
1.3 Similar to 1.1 but with secondary CPUs: Grace period is started
concurrently with secondary CPU booting, putting its idle task in
the holdout list because PF_IDLE isn't yet observed on it. It
stays then stuck in the holdout list until that CPU ever
schedules. The effect is mitigated here by all the smpboot
kthreads and the hotplug AP thread that must run to bring the
CPU up.
2) Spurious warning on RCU task trace that assumes offline CPU's idle
task is always PF_IDLE.
More issues have been found in RCU-tasks related to PF_IDLE which should
be fixed with later changes as those are not regressions:
3) The RCU-Tasks semantics consider the idle loop as a quiescent state,
however:
3.1 The boot code preceding the idle entry is included in this
quiescent state. Especially after the completion of kthreadd_done
after which init/1 can launch userspace concurrently. The window
is tiny before PF_IDLE is set but it exists.
3.2 Similarly, the boot code preceding the idle entry on secondary
CPUs is wrongly accounted as RCU tasks quiescent state.
Fixes: cff9b2332ab7 ("kernel/sched: Modify initial boot task idle setup")
Cc: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Cc: Sebastian Siewior <bigeasy@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
---
kernel/sched/core.c | 2 +-
kernel/sched/idle.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index ad960f97e4e1..b02dcbe98024 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -9269,7 +9269,7 @@ void __init init_idle(struct task_struct *idle, int cpu)
* PF_KTHREAD should already be set at this point; regardless, make it
* look like a proper per-CPU kthread.
*/
- idle->flags |= PF_KTHREAD | PF_NO_SETAFFINITY;
+ idle->flags |= PF_IDLE | PF_KTHREAD | PF_NO_SETAFFINITY;
kthread_set_per_cpu(idle, cpu);
#ifdef CONFIG_SMP
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 5007b25c5bc6..342f58a329f5 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -373,7 +373,6 @@ EXPORT_SYMBOL_GPL(play_idle_precise);
void cpu_startup_entry(enum cpuhp_state state)
{
- current->flags |= PF_IDLE;
arch_cpu_idle_prepare();
cpuhp_online_idle(state);
while (1)
--
2.34.1
