On Sat, Sep 09, 2023 at 10:28:36PM -0400, Joel Fernandes wrote: > Hi Paul, Frederic, ever since this recent patch got merged into all > recent stables: > https://lore.kernel.org/all/20230818200757.1808398-1-paul.gortmaker@xxxxxxxxxxxxx/ > .. > > .. I am seeing this happen a lot now causing rcutorture failures: > "NOHZ tick-stop error: local softirq work is pending" > > It looks like the "tick-stop error" as local_bh_blocked always returns > false on !PREEMPT_RT, so that patch itself seems correct. > > However, it appears the string in console-badness.sh is different: > > console-badness.sh:grep -v 'NOHZ tick-stop error: Non-RCU local > softirq work is pending, handler' > > So the string in the script needs an update? Looks like it, though I believe that there is a fix in the offing, at which point that "grep -v" should just be removed. Depending on timing, of course. > Also, considering that it is being grep -v'ed out, any background on > why this message is not bad and any history? Why is softirq work > pending when the tick is stopped? That was so long back that it is pretty hazy. I vaguely recall that this was considered to be in need of fixing, but a false positive from a torture-test perspective. Thanx, Paul