On Wed, Aug 16, 2023 at 6:57 PM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote: > > On Tue, Aug 15, 2023 at 07:09:49PM +0000, Joel Fernandes (Google) wrote: > > When debugging, it can be difficult to quickly find the ftrace dump > > within the console log, which in turn makes it difficult to process it > > independent of the result of the console output. This commit therefore > > copies the contents of the buffers into its own file to make it easier > > to locate and process the ftrace dump. The original ftrace dump is still > > available in the console log in cases where it is more convenient to > > process it there, for example, when you have a script that processes > > console output as well as ftrace-dump data. > > > > Also handle the case of multiple ftrace dumps potentially showing up in the > > log. Example for a file like [1], it will extract as [2]. > > > > [1]: > > foo > > foo > > Dumping ftrace buffer: > > --------------------------------- > > blah > > blah > > --------------------------------- > > more > > bar > > baz > > Dumping ftrace buffer: > > --------------------------------- > > blah2 > > blah2 > > --------------------------------- > > bleh > > bleh > > > > [2]: > > > > Ftrace dump 1: > > blah > > blah > > > > Ftrace dump 2: > > blah2 > > blah2 > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx> > > Very good, and I did queue this one. > > I fixed the indentation of the awk script. Perhaps your text editor is > being too smart for our good? ;-) Thanks! Yes the editor messing up is a possibility, I'll go look at that, though the indent seems still messed up in your dev branch: The line "/Dumping ftrace buffer:/ " has spaces, as does the "awk < $1" line. Is that intentional? All the following ones have tabs. thanks, - Joel
