This patch LGTM. Thanks! Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx> > From: Frederic Weisbecker <frederic@xxxxxxxxxx> > Sent: Wednesday, May 31, 2023 6:17 PM > To: Paul E . McKenney <paulmck@xxxxxxxxxx> > Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>; Frederic Weisbecker > <frederic@xxxxxxxxxx>; rcu <rcu@xxxxxxxxxxxxxxx>; Uladzislau Rezki > <urezki@xxxxxxxxx>; Neeraj Upadhyay <quic_neeraju@xxxxxxxxxxx>; Joel > Fernandes <joel@xxxxxxxxxxxxxxxxx>; Giovanni Gherdovich > <ggherdovich@xxxxxxx> > Subject: [PATCH 2/9] rcu: Use rcu_segcblist_segempty() instead of open > coding it > > This makes the code more readable. > > Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx> > --- > kernel/rcu/rcu_segcblist.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c index > f71fac422c8f..1693ea22ef1b 100644 > --- a/kernel/rcu/rcu_segcblist.c > +++ b/kernel/rcu/rcu_segcblist.c > @@ -368,7 +368,7 @@ bool rcu_segcblist_entrain(struct rcu_segcblist *rsclp, > smp_mb(); /* Ensure counts are updated before callback is entrained. > */ > rhp->next = NULL; > for (i = RCU_NEXT_TAIL; i > RCU_DONE_TAIL; i--) > - if (rsclp->tails[i] != rsclp->tails[i - 1]) > + if (!rcu_segcblist_segempty(rsclp, i)) > break; > rcu_segcblist_inc_seglen(rsclp, i); > WRITE_ONCE(*rsclp->tails[i], rhp); > @@ -551,7 +551,7 @@ bool rcu_segcblist_accelerate(struct rcu_segcblist > *rsclp, unsigned long seq) > * as their ->gp_seq[] grace-period completion sequence number. > */ > for (i = RCU_NEXT_READY_TAIL; i > RCU_DONE_TAIL; i--) > - if (rsclp->tails[i] != rsclp->tails[i - 1] && > + if (!rcu_segcblist_segempty(rsclp, i) && > ULONG_CMP_LT(rsclp->gp_seq[i], seq)) > break; > > -- > 2.40.1
