On Thu, Apr 06, 2023 at 11:14:30AM -0700, Paul E. McKenney wrote:
> Hello, Uladzislau,
>
> Would the patch below (to be folded into your original) be a good fix
> for the kerneldoc issue Stephen Rothwell pointed out?
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 7873a901c00f5c6d0f5b5b979584b4c7f1294563
> Author: Paul E. McKenney <paulmck@xxxxxxxxxx>
> Date: Thu Apr 6 11:06:26 2023 -0700
>
> squash! rcu/kvfree: Add debug check for GP complete for kfree_rcu_cpu list
>
> [ paulmck: Fix kerneldoc issue raised by Stephen Rothwell. ]
>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 9cc0a7766fd2..1be23a64f027 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2795,6 +2795,7 @@ struct kvfree_rcu_bulk_data {
> * struct kfree_rcu_cpu_work - single batch of kfree_rcu() requests
> * @rcu_work: Let queue_rcu_work() invoke workqueue handler after grace period
> * @head_free: List of kfree_rcu() objects waiting for a grace period
> + * @head_free_gp_snap: Grace-period snapshot to check for attempted premature frees.
> * @bulk_head_free: Bulk-List of kvfree_rcu() objects waiting for a grace period
> * @krcp: Pointer to @kfree_rcu_cpu structure
> */
>
Absolutely.
Reviewed-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
--
Uladzislau Rezki
