On 3/15/23 4:36 PM, Steven Rostedt wrote: > On Thu, 9 Mar 2023 14:45:21 +0100 > Uladzislau Rezki <urezki@xxxxxxxxx> wrote: > >>> The kvfree_rcu()'s single argument name is deprecated therefore >>> rename it to kvfree_rcu_mightsleep() variant. The goal is explicitly >>> underline that it is for sleepable contexts. >>> >>> Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> >>> Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx> >>> >> Could you please add you reviwed-by or Acked-by tags so we can bring >> our series with renaming for the next merge window? > > I don't know. Perhaps we should just apply this patch and not worry about > sleeping and whatnot. That's a cop out, just removing the one case you care about. Fact is the naming is awful, and the 1/2 argument thing is making it worse. If a big change is warranted, why not do it right and ACTUALLY get it right? -- Jens Axboe
