On 09/02/2023 18:31, Thomas Gleixner wrote:
On Thu, Feb 09 2023 at 15:41, Usama Arif wrote:
void mtrr_save_state(void)
{
+ static bool mtrr_saved;
int first_cpu;
if (!mtrr_enabled())
return;
+ if (system_state < SYSTEM_RUNNING) {
+ if (!mtrr_saved) {
+ mtrr_save_fixed_ranges(NULL);
+ mtrr_saved = true;
+ }
+ return;
+ }
+
first_cpu = cpumask_first(cpu_online_mask);
smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1);
So why is this relevant after the initial bringup? The BP MTRRs have
been saved already above, no?
Thanks,
tglx
I will let David confirm if this is correct and why he did it, but this
is what I thought while reviewing before posting v4:
- At initial boot (system_state < SYSTEM_RUNNING), when mtrr_save_state
is called in do_cpu_up at roughly the same time so MTRR is going to be
the same, we can just save it once and then reuse for other secondary
cores as it wouldn't have changed for the rest of the do_cpu_up calls.
- When the system is running and you offline and then online a CPU, you
want to make sure that hotplugged CPU gets the current MTRR (which might
have changed since boot?), incase the MTRR has changed after the system
has been booted, you save the MTRR of the first online CPU. When the
hotplugged CPU runs its initialisation code, its fixed-range MTRRs will
be updated with the newly saved fixed-range MTRRs.
So mainly for hotplug, but will let David confirm.
Thanks,
Usama
