On Wed, Feb 01, 2023 at 11:12:11AM -0800, Paul E. McKenney wrote: > On Wed, Feb 01, 2023 at 04:08:06PM +0100, Uladzislau Rezki (Sony) wrote: > > This small series is based on Paul's "dev" branch. Head is 6002817348a1c610dc1b1c01ff81654cdec12be4 > > it renames a single argument of k[v]free_rcu() to its new k[v]free_rcu_mightsleep() name. > > > > 1. > > The problem is that, recently we have run into a precedent when > > a user intended to give a second argument to kfree_rcu() API but > > forgot to do it in a code so a call became as a single argument > > of kfree_rcu() API. > > > > 2. > > Such mistyping can lead to hidden bags where sleeping is forbidden. > > > > 3. > > _mightsleep() prefix gives much more information for which contexts > > it can be used for. > > Thank you!!! > > I have queued these (aside from 10/13, which is being replaced by a > patch from Julian Anastasov) for further testing and review. And with > the usual wordsmithing. > Good. 10/13 will go with two arguments. So it is not needed. Just for confirmation. BTW, i see two complains from the robot due to 10/13 patch uses an old API name. > > If testing goes well, I might try to get 1/13 into the next merge window, > which would simplify things if maintainers want to take their patches > separately. > Thanks! -- Uladzislau Rezki
