Re: [PATCH v5 1/4] genirq: Fix the return type of kstat_cpu_irqs_sum()

Mukesh Ojha <quic_mojha@xxxxxxxxxxx> · Tue, 8 Nov 2022 19:52:12 +0530

Hi,

On 11/4/2022 7:41 PM, Zhen Lei wrote:
The type of member irqs_sum is unsigned long, so kstat_cpu_irqs_sum()
should also return unsigned long. Otherwise, the value maybe truncated.

Fixes: f2c66cd8eedd ("/proc/stat: scalability of irq num per cpu")
Reported-by: Elliott, Robert (Servers) <elliott@xxxxxxx>
Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh

---
  include/linux/kernel_stat.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h
index ddb5a358fd829f4..90e2fdc17d79ff8 100644
--- a/include/linux/kernel_stat.h
+++ b/include/linux/kernel_stat.h
@@ -75,7 +75,7 @@ extern unsigned int kstat_irqs_usr(unsigned int irq);
  /*
   * Number of interrupts per cpu, since bootup
   */
-static inline unsigned int kstat_cpu_irqs_sum(unsigned int cpu)
+static inline unsigned long kstat_cpu_irqs_sum(unsigned int cpu)
  {
  	return kstat_cpu(cpu).irqs_sum;
  }






