On Thu, Oct 6, 2022 at 3:11 PM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
[..]
> > static bool rcu_nocb_try_bypass(struct rcu_data *rdp, struct rcu_head *rhp,
> > - bool *was_alldone, unsigned long flags)
> > + bool *was_alldone, unsigned long flags,
> > + bool lazy)
> > {
> > unsigned long c;
> > unsigned long cur_gp_seq;
> > unsigned long j = jiffies;
> > long ncbs = rcu_cblist_n_cbs(&rdp->nocb_bypass);
> > + bool bypass_is_lazy = (ncbs == READ_ONCE(rdp->lazy_len));
>
> In the alphabet, "b" comes before "c". Picky, but it does make these
> things easier to find. Which can be important when you are searching
> for all occurrences of something -- nice to be able to find the variable
> in alpha order without interrupting your search.
For this comment, I cannot reorder it because it will break as ncbs
needs to be defined before it is used. I will leave this one alone if
it is Ok with you.
I am OK with all the other comments.
Thanks.
