> > This is the first I've seen kvfree_rcu() (that I actually noticed/remember, > I'm sure I probably was Cc'd on some patches). And I find the comment > around it very confusing: > > Specifically: > > > * kvfree_rcu(ptr); > * > * where @ptr is a pointer to kvfree(). > > The above suggests that you should pass a pointer to the actual function > kvfree to kvfree_rcu(), which is not what I believe is to be done. > > i.e. kvfree_rcu(kvfree) ??? > > Perhaps rewrite that to say: > > * where @ptr is the pointer to be freed by kvfree(). > > ? Indeed. I will fix that by sending a patch to change a description to be less confusing :) > > Other than that, the patch looks fine to me. > > Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > I will place your "Acked-by" to 9/9 one. Thanks! -- Uladzislau Rezki
