Linux kernel places strict semantics between NMI and maskable interrupt.
So does the RCU component, else deadlock may happen. But the current
arm64 entry code can partially breach this rule through calling
rcu_nmi_enter().
*** how a deadlock can happen if NMI mistaken as IRQ ***
rcu_nmi_enter()
{
if (rcu_dynticks_curr_cpu_in_eqs()) {
if (!in_nmi())
rcu_dynticks_task_exit();
...
if (!in_nmi()) {
instrumentation_begin();
rcu_cleanup_after_idle();
instrumentation_end();
}
...
} else if (!in_nmi()) {
instrumentation_begin();
rcu_irq_enter_check_tick();
}
}
If a NMI is mistaken as a maskable interrupt, rcu_irq_enter_check_tick()
can hit a deadlock, which is demonstrated by the following scenario:
note_gp_changes() runs in a task context
{
local_irq_save(flags); // this protects against irq, but not NMI
rnp = rdp->mynode;
...
raw_spin_trylock_rcu_node(rnp)
-------> broken in by (p)NMI, without taking __nmi_enter()
rcu_nmi_enter()
->__rcu_irq_enter_check_tick()
->raw_spin_lock_rcu_node(rdp->mynode);
deadlock happens!!!
}
*** On arm64, how pNMI mistaken as IRQ ***
On arm64, pNMI is an analogue to NMI. In essence, it is a higher
priority interrupt but not disabled by local_irq_disable().
In current implementation
1) If a pNMI from a context where IRQs were masked, it can be recognized
as nmi, and calls __nmi_enter() immediately. This is no problem.
2) But it causes trouble if a pNMI from a context where IRQs were
unmasked, and temporarily regarded as maskable interrupt. It is not
treated as NMI, i.e. calling nmi_enter() until reading from GIC.
__el1_irq()
{
irq_enter_rcu() ----> hit the deadlock bug
gic_handle_nmi()
nmi_enter()
nmi_exit()
irq_exit_rcu()
}
*** Remedy ***
If the irqchip level exposes an interface for detecting pNMI to arch level
code, it can meet the requirement at this early stage. That is the
interface (*interrupt_is_nmi)() in this patch.
Signed-off-by: Pingfan Liu <kernelfans@xxxxxxxxx>
Cc: Mark Rutland <mark.rutland@xxxxxxx>
Cc: Paul E. McKenney <paulmck@xxxxxxxxxx>
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: Will Deacon <will@xxxxxxxxxx>
Cc: Marc Zyngier <maz@xxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Joey Gouly <joey.gouly@xxxxxxx>
Cc: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
Cc: Julien Thierry <julien.thierry@xxxxxxx>
Cc: Yuichi Ito <ito-yuichi@xxxxxxxxxxx>
Cc: rcu@xxxxxxxxxxxxxxx
To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
---
arch/arm64/include/asm/irq.h | 1 +
arch/arm64/kernel/entry-common.c | 10 +++++++++-
arch/arm64/kernel/irq.c | 18 ++++++++++++++++++
3 files changed, 28 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
index fac08e18bcd5..f3eb13bfa65e 100644
--- a/arch/arm64/include/asm/irq.h
+++ b/arch/arm64/include/asm/irq.h
@@ -11,6 +11,7 @@ struct pt_regs;
int set_handle_irq(void (*handle_irq)(struct pt_regs *));
#define set_handle_irq set_handle_irq
int set_handle_fiq(void (*handle_fiq)(struct pt_regs *));
+int set_nmi_discriminator(bool (*discriminator)(void));
static inline int nr_legacy_irqs(void)
{
diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
index f7408edf8571..5a1a5dd66d04 100644
--- a/arch/arm64/kernel/entry-common.c
+++ b/arch/arm64/kernel/entry-common.c
@@ -260,6 +260,14 @@ static void do_interrupt_handler(struct pt_regs *regs,
extern void (*handle_arch_irq)(struct pt_regs *);
extern void (*handle_arch_fiq)(struct pt_regs *);
+extern bool (*interrupt_is_nmi)(void);
+
+static inline bool is_in_pnmi(struct pt_regs *regs)
+{
+ if (!interrupts_enabled(regs) || (*interrupt_is_nmi)())
+ return true;
+ return false;
+}
static void noinstr __panic_unhandled(struct pt_regs *regs, const char *vector,
unsigned int esr)
@@ -454,7 +462,7 @@ static void noinstr el1_interrupt(struct pt_regs *regs,
{
write_sysreg(DAIF_PROCCTX_NOIRQ, daif);
- if (IS_ENABLED(CONFIG_ARM64_PSEUDO_NMI) && !interrupts_enabled(regs))
+ if (IS_ENABLED(CONFIG_ARM64_PSEUDO_NMI) && is_in_pnmi(regs))
__el1_pnmi(regs, handler);
else
__el1_irq(regs, handler);
diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c
index bda49430c9ea..fabed09ed966 100644
--- a/arch/arm64/kernel/irq.c
+++ b/arch/arm64/kernel/irq.c
@@ -81,8 +81,14 @@ static void default_handle_fiq(struct pt_regs *regs)
panic("FIQ taken without a root FIQ handler\n");
}
+static bool default_nmi_discriminator(void)
+{
+ return false;
+}
+
void (*handle_arch_irq)(struct pt_regs *) __ro_after_init = default_handle_irq;
void (*handle_arch_fiq)(struct pt_regs *) __ro_after_init = default_handle_fiq;
+bool (*interrupt_is_nmi)(void) __ro_after_init = default_nmi_discriminator;
int __init set_handle_irq(void (*handle_irq)(struct pt_regs *))
{
@@ -104,6 +110,18 @@ int __init set_handle_fiq(void (*handle_fiq)(struct pt_regs *))
return 0;
}
+#if IS_ENABLED(CONFIG_ARM64_PSEUDO_NMI)
+
+int __init set_nmi_discriminator(bool (*discriminator)(void))
+{
+ if (interrupt_is_nmi != default_nmi_discriminator)
+ return -EBUSY;
+
+ interrupt_is_nmi = discriminator;
+ return 0;
+}
+#endif
+
void __init init_IRQ(void)
{
init_irq_stacks();
--
2.31.1
