Thank both of you for correcting my mistakes. I do benefit a lot from your emails. Cheers Zhouyi On Tue, Aug 24, 2021 at 9:47 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > On Wed, Aug 11, 2021 at 10:44:21AM +0800, Boqun Feng wrote: > > Hi, > > > > On Wed, Aug 11, 2021 at 05:03:19AM +0800, Zhouyi Zhou wrote: > > > Hi Peter, > > > I think comments in wait-type checks may benifit from some comments > > > improvement. > > > > Thanks for looking into this! > > > > Even for an RFC patch, it's better that you write a proper commit log, > > and note that you can put all this background information right after > > the "---" line, if you think that will help people review it. > > > > > I recklessly add Paul to signed-off-by, because I asked his opinion > > > about comment in rcu_read_lock_bh part. > > > > > > > Probably a Suggested-by will suffice, but I leave that to Paul ;-) > > This, also since Paul never actually touched the patch. > > > > Thanks a lot > > > Zhouyi > > > > > > Signed-off-by: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx> > > > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> > > > > Please make you the last one in the "Signed-off-by" list, see > > Documentation/process/submitting-patches.rst: > > > > "Notably, the last Signed-off-by: must always be that of the developer > > submitting the patch." > > The first sob should be that of the author, and given that's the same > person as the submitter in this case, he's got a problem at his hands > ;-) >
