From: kernel test robot <lkp@xxxxxxxxx> NULL check before kfree is not needed. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 9f7e887e648c ("rcu/tree: Allocate a page when caller is preemptible") Acked-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx> Signed-off-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> --- kernel/rcu/tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index cc998d7..4a85ea2 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_struct *work) bkvhead[i] = NULL; krc_this_cpu_unlock(krcp, flags); - if (bkvhead[i]) - kfree(bkvhead[i]); + kfree(bkvhead[i]); cond_resched_tasks_rcu_qs(); } -- 2.9.5