Re: [PATCH rcu-dev 1/2] rcuperf: Add ability to increase object allocation size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Joel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rcu/dev]
[also build test WARNING on rcu/rcu/next linus/master v5.6-rc5 next-20200306]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/rcuperf-Add-ability-to-increase-object-allocation-size/20200306-110336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
config: i386-randconfig-a001-20200308 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:15:0,
                    from kernel/rcu/rcuperf.c:13:
   kernel/rcu/rcuperf.c: In function 'kfree_perf_init':
>> kernel/rcu/rcuperf.c:726:65: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat=]
     pr_alert("kfree object size=%lu\n", kfree_mult * sizeof(struct kfree_obj));
                                                                    ^
   include/linux/printk.h:300:35: note: in definition of macro 'pr_alert'
     printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
                                      ^

vim +726 kernel/rcu/rcuperf.c

   708	
   709	static int __init
   710	kfree_perf_init(void)
   711	{
   712		long i;
   713		int firsterr = 0;
   714	
   715		kfree_nrealthreads = compute_real(kfree_nthreads);
   716		/* Start up the kthreads. */
   717		if (shutdown) {
   718			init_waitqueue_head(&shutdown_wq);
   719			firsterr = torture_create_kthread(kfree_perf_shutdown, NULL,
   720							  shutdown_task);
   721			if (firsterr)
   722				goto unwind;
   723			schedule_timeout_uninterruptible(1);
   724		}
   725	
 > 726		pr_alert("kfree object size=%lu\n", kfree_mult * sizeof(struct kfree_obj));
   727	
   728		kfree_reader_tasks = kcalloc(kfree_nrealthreads, sizeof(kfree_reader_tasks[0]),
   729				       GFP_KERNEL);
   730		if (kfree_reader_tasks == NULL) {
   731			firsterr = -ENOMEM;
   732			goto unwind;
   733		}
   734	
   735		for (i = 0; i < kfree_nrealthreads; i++) {
   736			firsterr = torture_create_kthread(kfree_perf_thread, (void *)i,
   737							  kfree_reader_tasks[i]);
   738			if (firsterr)
   739				goto unwind;
   740		}
   741	
   742		while (atomic_read(&n_kfree_perf_thread_started) < kfree_nrealthreads)
   743			schedule_timeout_uninterruptible(1);
   744	
   745		torture_init_end();
   746		return 0;
   747	
   748	unwind:
   749		torture_init_end();
   750		kfree_perf_cleanup();
   751		return firsterr;
   752	}
   753	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux