On Tue, Oct 15, 2019 at 11:55:24AM +0100, Ben Dooks wrote: > The following are not used outside the unit they are > declared in, so make them static to avoid the following > sparse warnings: > > kernel/rcu/rcu_segcblist.c:91:6: warning: symbol 'rcu_segcblist_set_len' was not declared. Should it be static? > kernel/rcu/rcu_segcblist.c:107:6: warning: symbol 'rcu_segcblist_add_len' was not declared. Should it be static? > kernel/rcu/rcu_segcblist.c:137:6: warning: symbol 'rcu_segcblist_xchg_len' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> Good catch, but commit 292d1bb2 ("rcu: Several rcu_segcblist functions can be static") beat you to it by a month or two. This commit is still in -rcu, but will be part of my pull request in a couple of weeks. See -rcu branch "dev": git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git Thanx, Paul > --- > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx> > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> > Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> > Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx> > Cc: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> > Cc: rcu@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > --- > kernel/rcu/rcu_segcblist.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c > index 495c58ce1640..cbc87b804db9 100644 > --- a/kernel/rcu/rcu_segcblist.c > +++ b/kernel/rcu/rcu_segcblist.c > @@ -88,7 +88,7 @@ struct rcu_head *rcu_cblist_dequeue(struct rcu_cblist *rclp) > } > > /* Set the length of an rcu_segcblist structure. */ > -void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v) > +static void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v) > { > #ifdef CONFIG_RCU_NOCB_CPU > atomic_long_set(&rsclp->len, v); > @@ -104,7 +104,7 @@ void rcu_segcblist_set_len(struct rcu_segcblist *rsclp, long v) > * This increase is fully ordered with respect to the callers accesses > * both before and after. > */ > -void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v) > +static void rcu_segcblist_add_len(struct rcu_segcblist *rsclp, long v) > { > #ifdef CONFIG_RCU_NOCB_CPU > smp_mb__before_atomic(); /* Up to the caller! */ > @@ -134,7 +134,7 @@ void rcu_segcblist_inc_len(struct rcu_segcblist *rsclp) > * with the actual number of callbacks on the structure. This exchange is > * fully ordered with respect to the callers accesses both before and after. > */ > -long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v) > +static long rcu_segcblist_xchg_len(struct rcu_segcblist *rsclp, long v) > { > #ifdef CONFIG_RCU_NOCB_CPU > return atomic_long_xchg(&rsclp->len, v); > -- > 2.23.0 >