On Fri, Oct 04, 2019 at 11:54:02PM +0200, Jonathan Neuschäfer wrote: > Without this patch, Sphinx shows "variable arguments" as the description > of the cond argument, rather than the intended description, and prints > the following warnings: > > ./include/linux/rculist.h:374: warning: Excess function parameter 'cond' description in 'list_for_each_entry_rcu' > ./include/linux/rculist.h:651: warning: Excess function parameter 'cond' description in 'hlist_for_each_entry_rcu' > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> Applied for testing and review, thank you! Joel, does this look sane to you? Thanx, Paul > --- > include/linux/rculist.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/rculist.h b/include/linux/rculist.h > index 4158b7212936..61c6728a71f7 100644 > --- a/include/linux/rculist.h > +++ b/include/linux/rculist.h > @@ -361,7 +361,7 @@ static inline void list_splice_tail_init_rcu(struct list_head *list, > * @pos: the type * to use as a loop cursor. > * @head: the head for your list. > * @member: the name of the list_head within the struct. > - * @cond: optional lockdep expression if called from non-RCU protection. > + * @cond...: optional lockdep expression if called from non-RCU protection. > * > * This list-traversal primitive may safely run concurrently with > * the _rcu list-mutation primitives such as list_add_rcu() > @@ -636,7 +636,7 @@ static inline void hlist_add_behind_rcu(struct hlist_node *n, > * @pos: the type * to use as a loop cursor. > * @head: the head for your list. > * @member: the name of the hlist_node within the struct. > - * @cond: optional lockdep expression if called from non-RCU protection. > + * @cond...: optional lockdep expression if called from non-RCU protection. > * > * This list-traversal primitive may safely run concurrently with > * the _rcu list-mutation primitives such as hlist_add_head_rcu() > -- > 2.20.1 >