On Sat, Aug 17, 2019 at 12:43:08AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > > > xchg() on a bool is causing issues on riscv and arm32. > > > > Indeed, it seems best not to use xchg() on any type that's not 32 bits > > long or that's not the CPU's native word size. Probably we should update > > the documentation. > > I would endorse any such documentation effort ;-) > > > > Please squash this into the -rcu dev branch to resolve the issue. > > > > > > Please squash this fix. Done, please see below for updated version. > > > Fixes: -rcu dev commit 3cbd3aa7d9c7bdf ("rcu/tree: Add basic support for kfree_rcu() batching") > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx> > > > > Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.9999.1908161931110.32497@xxxxxxxxxxxxxxxx/T/#me9956f66cb611b95d26ae92700e1d901f46e8c59 > > Reviewed-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx> I added the link, thank you Paul! If you meant the Reviewed-by to apply to the entire kfree_rcu() patch, I will of course be very happy to apply that as well. > Thanks Paul! And nice to meet you again after many years ;-) Glad to see you > working on riscv. What Joel said! ;-) Thanx, Paul