On Tue, 6 Aug 2019 18:17:07 -0700 "Paul E. McKenney" <paulmck@xxxxxxxxxxxxx> wrote: > On Tue, Aug 06, 2019 at 08:40:55PM -0400, Steven Rostedt wrote: > > On Tue, 6 Aug 2019 17:35:01 -0700 > > "Paul E. McKenney" <paulmck@xxxxxxxxxxxxx> wrote: > > > > > > > + // Don't use ->nocb_bypass during early boot. > > > > > > > > Very minor nit: comment style should be /* */ > > > > > > I thought that Linus said that "//" was now OK. Am I confused? > > > > Have a link? > > https://lkml.org/lkml/2016/7/8/625 > The (c) form is particularly good for things like enum or structure member comments at the end of code, where you might want to align things up, but the ending comment marker ends up being visually pretty distracting (and lining _that_ up is too much make-believe work). I think it's still for special occasions, and the above example doesn't look like one of them ;-) I basically avoid the '//' comment, as it just adds inconstancy. -- Steve
