On Tue, Apr 09, 2019 at 10:38:20PM -0400, Steven Rostedt wrote:
> On Tue, 9 Apr 2019 21:14:18 -0400
> "Joel Fernandes (Google)" <joel@xxxxxxxxxxxxxxxxx> wrote:
>
> > /*
> > - * Mark ro_after_init section with SHF_RO_AFTER_INIT so that
> > + * These are section names marked with SHF_RO_AFTER_INIT so that
>
> I'm curious to this much of a change. Wouldn't just making "section"
> plural also work?
>
> "Mark ro_after_init sections with ..."
Yes, I will change it to that and actually this comment change should go in
the previous patch so I'll squash it into that.
> Other than that, the two patches look fine to me.
Could I add your Reviewed-by in the respin?
thanks,
- Joel
> -- Steve
>
> > * layout_sections() can put it in the right place.
> > * Note: ro_after_init sections also have SHF_{WRITE,ALLOC} set.
> > */
> > @@ -3314,6 +3314,13 @@ static char *ro_after_init_sections[] = {
