Re: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please ignore this patch. It should use wait_barrier first before
returning the discard request with REQ_NOWATI to the upper layer.

Regards
Xiao

On Tue, Mar 4, 2025 at 5:10 PM Xiao Ni <xni@xxxxxxxxxx> wrote:
>
> There is no need to print warn call trace. And it also can confuse
> qe and mark test case failure.
>
> Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> ---
>  drivers/md/raid10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 15b9ae5bf84d..0441691130c7 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
>         if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
>                 return -EAGAIN;
>
> -       if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
> +       if (bio->bi_opf & REQ_NOWAIT) {
>                 bio_wouldblock_error(bio);
>                 return 0;
>         }
> --
> 2.32.0 (Apple Git-132)
>
>






[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux