Re: [PATCH 1/1] md/raid10: Don't print warn calltrace for discard with REQ_NOWAIT

[Paul Menzel <pmenzel@xxxxxxxxxxxxx>]

Dear Xiao,


Thank you for your patch.


Am 04.03.25 um 10:09 schrieb Xiao Ni:
> There is no need to print warn call trace. And it also can confuse

Why is there no need?

> qe and mark test case failure.

What is *qe*?

> Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> ---
>   drivers/md/raid10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 15b9ae5bf84d..0441691130c7 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -1631,7 +1631,7 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio)
>   	if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
>   		return -EAGAIN;
>   
> -	if (WARN_ON_ONCE(bio->bi_opf & REQ_NOWAIT)) {
> +	if (bio->bi_opf & REQ_NOWAIT) {
>   		bio_wouldblock_error(bio);
>   		return 0;
>   	}


Kind regards,

Paul