Christoph, > The code that automatically creates a integrity payload and generates / > verifies the checksums for bios that don't have submitter-provided > integrity payload currently sits right in the middle of the block > integrity metadata infrastruture. The original split was intentional: Stuff that mucks with bios in bio-integrity.c and stuff that mucks with the block device or queue in blk-integrity.c. I never really thought of the generation/verification as being separate from attaching the PI to the bio. However, I don't mind moving the code out at all. That's fine. I'm not sure I'm so keen on integrity-default.c, though. But naming is hard. bio-integrity-auto.c, maybe? -- Martin K. Petersen Oracle Linux Engineering