On Fri, Jan 17, 2025 at 10:27:22PM +0100, Mikulas Patocka wrote: > > > On Fri, 17 Jan 2025, Mike Snitzer wrote: > > > On Thu, Jan 16, 2025 at 05:02:53PM +0000, John Garry wrote: > > > This series introduces initial device mapper atomic write support. > > > > > > Since we already support stacking atomic writes limits, it's quite > > > straightforward to support. > > > > > > Personalities dm-linear, dm-stripe, and dm-raid1 are supported here, and > > > more personalities could be supported in future. > > > > > > This is still an RFC as I would like to test further. > > > > > > Based on 3d9a9e9a77c5 (block/for-6.14/block) block: limit disk max > > > sectors to (LLONG_MAX >> 9) > > > > > > Changes to v1: > > > - Generic block layer atomic writes enable flag and dm-table rework > > > - Add dm-stripe and dm-raid1 support > > > - Add bio_trim() patch > > > > This all looks good. > > > > Mikulas, we need Jens to pick up patches 1 and 2. I wouldn't be > > opposed to him taking the entire set but I did notice the DM core > > (ioctl) version and the 3 DM targets that have had atomic support > > added need their version numbers bumped. Given that, likely best for > > you (Mikulas) to pick up patches 3-8 after rebasing on Jens' latest > > for-6.14/block branch (once Jens picks up patches 1 and 2). > > > > Jens, you cool with picking up patches 1+2 for 6.14? Or too late and > > we circle back to this for 6.15? > > > > Either way, for the series: > > > > Reviewed-by: Mike Snitzer <snitzer@xxxxxxxxxx> > > Hi > > I rebased on Jens' block tree, applied the patches 3-8, increased > DM_VERSION_MINOR, DM_VERSION_EXTRA, increased version numbers in > dm-linear, dm-stripe, dm-raid1 and uploaded it to git.kernel.org. > > You can check it if it's correct. Looks good, thanks! Mike
